mirrors/apollo-backend
2
0
Fork 0
mirror of https://github.com/christianselig/apollo-backend synced 2024-11-25 05:07:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

don't be clever with server errors

Browse source
This commit is contained in:
Andre Medeiros 2021-09-25 14:42:53 -04:00
parent b9e6950cb1
commit 203b6600d5
1 changed files with 1 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
internal/reddit/client.go
View file

@ -123,16 +123,7 @@ func (rac *AuthenticatedClient) request(r *Request, rh ResponseHandler, empty in
if resp.StatusCode != 200 { if resp.StatusCode != 200 {
_ = rac.statsd.Incr("reddit.api.errors", r.tags, 0.1) _ = rac.statsd.Incr("reddit.api.errors", r.tags, 0.1)
return nil, ServerError{resp.StatusCode}
// Try to parse a json error. Otherwise we generate a generic one
parser := rac.pool.Get()
defer rac.pool.Put(parser)
val, jerr := parser.ParseBytes(bb)
if jerr != nil {
return nil, ServerError{resp.StatusCode}
}
return nil, NewError(val, resp.StatusCode)
} }
if r.emptyResponseBytes > 0 && len(bb) == r.emptyResponseBytes { if r.emptyResponseBytes > 0 && len(bb) == r.emptyResponseBytes {