From 203b6600d55f2cc4778b33aafe4117f7b5d3fa29 Mon Sep 17 00:00:00 2001 From: Andre Medeiros Date: Sat, 25 Sep 2021 14:42:53 -0400 Subject: [PATCH] don't be clever with server errors --- internal/reddit/client.go | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/internal/reddit/client.go b/internal/reddit/client.go index 1550d6e..37adb9d 100644 --- a/internal/reddit/client.go +++ b/internal/reddit/client.go @@ -123,16 +123,7 @@ func (rac *AuthenticatedClient) request(r *Request, rh ResponseHandler, empty in if resp.StatusCode != 200 { _ = rac.statsd.Incr("reddit.api.errors", r.tags, 0.1) - - // Try to parse a json error. Otherwise we generate a generic one - parser := rac.pool.Get() - defer rac.pool.Put(parser) - - val, jerr := parser.ParseBytes(bb) - if jerr != nil { - return nil, ServerError{resp.StatusCode} - } - return nil, NewError(val, resp.StatusCode) + return nil, ServerError{resp.StatusCode} } if r.emptyResponseBytes > 0 && len(bb) == r.emptyResponseBytes {