From 4719ee091e263b135d54c0b2d9428b02c31dff0f Mon Sep 17 00:00:00 2001 From: Andre Medeiros Date: Thu, 8 Jul 2021 20:14:12 -0400 Subject: [PATCH] clear lock after job succeeds too --- cmd/apollo-worker-notifications/main.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/cmd/apollo-worker-notifications/main.go b/cmd/apollo-worker-notifications/main.go index 9032bce..b34d8a8 100644 --- a/cmd/apollo-worker-notifications/main.go +++ b/cmd/apollo-worker-notifications/main.go @@ -182,6 +182,8 @@ func NewConsumer(tag int, logger *logrus.Logger, statsd *statsd.Client, redis *r func (c *Consumer) Consume(delivery rmq.Delivery) { ctx := context.Background() + defer c.redis.HDel(ctx, "locks:accounts", delivery.Payload()) + c.logger.WithFields(logrus.Fields{ "accountID": delivery.Payload(), }).Debug("starting job") @@ -305,7 +307,6 @@ func (c *Consumer) Consume(delivery rmq.Delivery) { delivery.Reject() } else { - c.redis.HDel(ctx, "locks:accounts", delivery.Payload()) delivery.Ack() } return @@ -335,7 +336,6 @@ func (c *Consumer) Consume(delivery rmq.Delivery) { "accountID": delivery.Payload(), }).Debug("populating first message ID to prevent spamming") - c.redis.HDel(ctx, "locks:accounts", delivery.Payload()) delivery.Ack() } return @@ -396,7 +396,6 @@ func (c *Consumer) Consume(delivery rmq.Delivery) { } } - c.redis.HDel(ctx, "locks:accounts", delivery.Payload()) delivery.Ack() c.logger.WithFields(logrus.Fields{